Hi,

+1 non-binding

I checked:
- mvn package

Minor issue:
I find a strange thing...
After downloading the release source file [1], and unzip the file on
MacOS, I find all files's creation time is 1979-11-30...
It is not a big issue (or it can not be called as an issue), but not
very friendly...

[1] 
https://dist.apache.org/repos/dist/dev/plc4x/build-tools/plc4x-site-skin/1.1.0/rc1/rc1/apache-plc4x-site-skin-1.1.0-source-release.zip

Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University

 黄向东
清华大学 软件学院

Lukas Ott <[email protected]> 于2021年9月9日周四 下午3:18写道:
>
> +1 (binding)
>
> Actions performed:
> Downloaded all staged artifacts under the url specified in the release vote
> email into a directory we’ll now call download-dir.
> Verified the signature is correct
> gpg: Korrekte Signatur von "Christofer Dutz (Apache Comitter) <
> [email protected]>"
> Verified  the SHA512 hashes
> Verified  the existence of LICENSE, NOTICE, README, RELEASE_NOTES files in
> the extracted source bundle.
> Verified  the content of LICENSE, NOTICE, README, RELEASE_NOTES files in
> the extracted source bundle.
> Run RAT externally with no surprises
> Successfully built with Ubuntu 20.04 and
> openjdk 11.0.11 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
>
> Am Mi., 8. Sept. 2021 um 20:41 Uhr schrieb Christofer Dutz <
> [email protected]>:
>
> > Apache PLC4X Build-Tools Site-Skink 1.1.0 has been staged under [2]
> > and it's time to vote on accepting it for release.
> >
> > All Maven artifacts are available under [1]. Voting will be open for 72hr.
> >
> > A minimum of 3 binding +1 votes and more binding +1 than binding -1
> > are required to pass.
> >
> > Repository: https://gitbox.apache.org/repos/asf/plc4x-build-tools.git
> > Release tag: site-skin/v1.1.0
> > Hash for the release tag: be516d634bcff0c09c714e948fd5958915f47771
> >
> > Per [3] "Before voting +1 PMC members are required to download
> > the signed source code package, compile it as provided, and test
> > the resulting executable on their own platform, along with also
> > verifying that the package meets the requirements of the ASF policy
> > on releases."
> >
> > You can achieve the above by following [4].
> >
> > [ ]  +1 accept (indicate what you validated - e.g. performed the non-RM
> > items in [4])
> > [ ]  -1 reject (explanation required)
> >
> >
> > [1] https://repository.apache.org/content/repositories/orgapacheplc4x-1035
> > [2]
> > https://dist.apache.org/repos/dist/dev/plc4x/build-tools/plc4x-site-skin/1.1.0/rc1/
> > [3] https://www.apache.org/dev/release/validation.html#approving-a-release
> > [4] https://plc4x.apache.org/developers/release/validation.html
> >

Reply via email to