Hi, The modbus string branch can be deleted. It has an implementation of read/writing strings with set lengths for Java, the same way that the S7 driver specifies it. For PLC4X-304, Lukasz had a comment about it being able to be applied to the 0.8 branch, but otherwise it seems like it can be removed.
feature/modbusrtu wasn't on the list, but I think we should keep it. It should be in a working state (Although I don't have anything but a simulator to test with) but just needs some clean up and documentation. Kind Regards Ben On Wed, Dec 15, 2021 at 11:30 PM Cesar Garcia <[email protected]> wrote: > Hi everyone, > > +1 > > s7event<https://github.com/apache/plc4x/tree/s7event> (I think this is > merged, right?) > > > > El mié, 15 dic 2021 a las 5:23, Christofer Dutz (< > [email protected]>) > escribió: > > > Hi all, > > > > I have just tried to revive a not so old branch (feature/plc4net) and > that > > is a LOT of work. > > > > Considering how many super-old branches we have; I would like to propose > > to clean up all branches that haven't been touched for at least a year. > > (I know one or two I stripped from this list, because they were mine and > I > > want to update them or they are release branches, which I think we should > > keep) > > > > Right now, we have 48 branches. > > > > The ones I would delete are: > > > > Stale for longer than 12 months: > > feature/code-gen-julian< > > https://github.com/apache/plc4x/tree/feature/code-gen-julian> (3 years) > > too-many-open-files< > > https://github.com/apache/plc4x/tree/too-many-open-files> (2 years) > > fix-netty-usage<https://github.com/apache/plc4x/tree/fix-netty-usage> (2 > > years) > > fix-bytebuff-leaks< > https://github.com/apache/plc4x/tree/fix-bytebuff-leaks> > > (2 years) > > feature/big_integer_support_on_driver_base< > > > https://github.com/apache/plc4x/tree/feature/big_integer_support_on_driver_base > > > > (2 years) > > feature/optimizer-for-next-gen< > > https://github.com/apache/plc4x/tree/feature/optimizer-for-next-gen> (2 > > years) > > develop-test<https://github.com/apache/plc4x/tree/develop-test> (2 > years) > > feature/link-layer-discovery-protocol< > > > https://github.com/apache/plc4x/tree/feature/link-layer-discovery-protocol > > > > (2 years) > > feature/profinet<https://github.com/apache/plc4x/tree/feature/profinet> > > (2 years) > > feature/plc-simulator< > > https://github.com/apache/plc4x/tree/feature/plc-simulator> (2 years) > > feature/bacnet-active< > > https://github.com/apache/plc4x/tree/feature/bacnet-active> (2 years) > > bugfix/close-eventloop-after-channel< > > > https://github.com/apache/plc4x/tree/bugfix/close-eventloop-after-channel> > > (16 months) > > feature/parser-tracing< > > https://github.com/apache/plc4x/tree/feature/parser-tracing> (16 months) > > issue/PLC4X-258<https://github.com/apache/plc4x/tree/issue/PLC4X-258> > (13 > > months) > > feature/grpc-proxy< > https://github.com/apache/plc4x/tree/feature/grpc-proxy> > > (13 months) > > issue/PLC4X-252<https://github.com/apache/plc4x/tree/issue/PLC4X-252> > (14 > > months) > > > > Newer branches, that I think might be obsolete or forgotten to be deleted > > ... > > feature/sparkplug-gateway< > > https://github.com/apache/plc4x/tree/feature/sparkplug-gateway> (9 > months) > > fix/modbus_string<https://github.com/apache/plc4x/tree/fix/modbus_string > > > > (is this obsolete? What's the status on this?) > > feature/profinet2<https://github.com/apache/plc4x/tree/feature/profinet2 > > > > (I think this is merged, right?) > > feature/updated-mspec-string< > > https://github.com/apache/plc4x/tree/feature/updated-mspec-string> (I > > think this is obsolete, right?) > > issue/PLC4X-304<https://github.com/apache/plc4x/tree/issue/PLC4X-304> (I > > think this is merged, right?) > > issue/PLC4X-311<https://github.com/apache/plc4x/tree/issue/PLC4X-311> (I > > think this is merged, right?) > > s7event<https://github.com/apache/plc4x/tree/s7event> (I think this is > > merged, right?) > > > > So, anyone wanting to keep one of these branches ... please reply in > let's > > say the next 7 days and if I don't hear back from you, I'll delete the > > listed branches. > > > > Chris > > > > > > -- > *CEOS Automatización, C.A.* > *GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,* > *PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,* > > *FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI* > *Ing. César García* > > *Cel: +58 414-760.98.95* > > *Hotline Técnica SIEMENS: 0800 1005080* > > *Email: [email protected] > <[email protected]>* >
