PR-354 contains an updated plc4py/pom.xml which uses pipenv, the Pipfile is in .gitignore and is generated from setup.py as part of the build.
This makes it so we don't have to maintain the Pipfile and setup.py and can just use setup.py. However the downside is that running maven install takes way too long as it resolves the dependencies each time. PyCharm also thinks it's an external library when using an PipEnv interpreter as the Pipfile treats plc4py as an imported package. This thread is kind of interesting. https://github.com/pypa/pipenv/issues/1911 Using venv we don't need an external dependency, and we can specify the location of the venv. I'm kind of leaning towards it. On Fri, Apr 22, 2022 at 1:15 AM Otto Fowler <[email protected]> wrote: > +1 to moving on from poetry to setuptools. > I’m sure we can find some apache examples for pushing to pypi that make up > for what poetry automates > > From: Lukas Ott <[email protected]> <[email protected]> > Reply: [email protected] <[email protected]> <[email protected]> > Date: April 19, 2022 at 15:52:24 > To: [email protected] <[email protected]> <[email protected]> > Subject: PLC4Py - Change of Build System - Poetry is for the time beeing > not suitable anymore > > Hello PLC4X Developers, > > As shown here: https://github.com/apache/plc4x/pull/348 > > We started the discussion to change our build system. > > Poetry has at the moment an increasing amount of issues: > https://github.com/python-poetry/poetry/issues > > Which are not fixed soon. Even that Poetry is a good solution and was the > right decision to begin with. We need a solution that works for our > purposes. > > Therefore here are some links comparing different possibilities: > https://remastr.com/blog/pip-pipenv-poetry-comparison > > > https://www.reddit.com/r/Python/comments/limd9t/poetry_vs_pipenv_vs_piptools_what_do_you_use/ > > My suggestion would be to go with https://pypi.org/project/pip-tools/ It > is > more low-level but also more stable / reliable. > > What are your thoughts? > > Thank you Ben! It is really fun to read / see your work in the Pull request > :-) > > Cheers, > Lukas >
