splatch commented on code in PR #352:
URL: https://github.com/apache/plc4x/pull/352#discussion_r857035719
##########
protocols/modbus/src/main/resources/protocols/modbus/modbus.mspec:
##########
@@ -416,6 +416,15 @@
['WCHAR' List
[array uint 16 value count 'numberOfValues']
]
+ ['STRING','1' STRING
+ [simple vstring '8' value encoding='"UTF-8"']
+ ]
+ ['STRING' List
+ [simple vstring '8 * numberOfValues' value encoding='"UTF-8"']
Review Comment:
Looking at S7 fields I see that its a special case regexp which is not going
to fly with modbus unless we modify its definition. Will try cooking something
there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
