+1 (binding) Ben
[OK] Download all staged artifacts under the url specified in the release vote email. [OK] Verify the signature is correct. [OK] Check if the signature references an Apache email address. [OK] Verify the SHA512 hashes. [OK] Unzip the archive. [OK] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle. [OK] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle. [OK] [RM] Verify the staged source README, RELEASE_NOTE files correspond to those in the extracted source bundle. [OK] [RM] Run RAT externally to ensure there are no surprises. [OK] Search for SNAPSHOT references [OK] Search for Copyright references, and if they are in headers, make sure these files containing them are mentioned in the LICENSE file. [MINOR] Build the project according to the information in the README.md file. [OK] [RM] Build the project with all with-xyz profiles and tests enabled and an empty maven local repo. mvnw issue, I agree with Chris. On Fri, Sep 23, 2022 at 2:29 AM Sebastian Rühl <sru...@apache.org> wrote: > +1 (binding) > > Sebastian > > [OK] Download all staged artifacts under the url specified in the release > vote email. > [OK] Verify the signature is correct. > [OK] Check if the signature references an Apache email address. > [OK] Verify the SHA512 hashes. > [OK] Unzip the archive. > [OK] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files > in the extracted source bundle. > [OK] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files in > the extracted source bundle. > [OK] Search for SNAPSHOT references > [OK] Search for Copyright references, and if they are in headers, make > sure these files containing them are mentioned in the LICENSE file. > [MINOR] Build the project according to the information in the README.md > file. > > See note from chris on missing .mvn directory > > On 2022/09/22 12:16:50 Christofer Dutz wrote: > > Apache PLC4X Build-Tools Code-Generation 1.6.0 has been staged under [2] > > and it’s time to vote on accepting it for release. > > > > All Maven artifacts are available under [1]. Voting will be open for > 72hr. > > > > A minimum of 3 binding +1 votes and more binding +1 than binding -1 > > are required to pass. > > > > Repository: https://gitbox.apache.org/repos/asf/plc4x-build-tools.git > > Release tag: releases/code-generation/1.6.0 > > Hash for the release tag: 9e91bf424bc4ee581158a200e67edaf02825097d > > > > Per [3] "Before voting +1 PMC members are required to download > > the signed source code package, compile it as provided, and test > > the resulting executable on their own platform, along with also > > verifying that the package meets the requirements of the ASF policy > > on releases." > > > > You can achieve the above by following [4]. > > > > [ ] +1 accept (indicate what you validated - e.g. performed the > non-RM items in [4]) > > [ ] -1 reject (explanation required) > > > > > > [1] > https://repository.apache.org/content/repositories/orgapacheplc4x-1042 > > [2] > https://dist.apache.org/repos/dist/dev/plc4x/build-tools/code-generation/1.6.0/rc1/ > > [3] > https://www.apache.org/dev/release/validation.html#approving-a-release > > [4] https://plc4x.apache.org/developers/release/validation.html > > > > >
