chrisdutz commented on code in PR #545:
URL: https://github.com/apache/plc4x/pull/545#discussion_r1064040985
##########
plc4go/protocols/modbus/readwrite/model/DataItem.go:
##########
@@ -24,30 +24,48 @@ import (
"github.com/apache/plc4x/plc4go/spi/utils"
"github.com/apache/plc4x/plc4go/spi/values"
"github.com/pkg/errors"
+ "math"
)
// Code generated by code-generation. DO NOT EDIT.
Review Comment:
I hope you read this line and didn't manually edit this file ... because the
next time you'll run the full maven build these changes are going to be
replaced with the old values.
##########
plc4go/protocols/modbus/readwrite/ParserHelper.go:
##########
@@ -40,7 +40,7 @@ func (m ModbusParserHelper) Parse(typeName string, arguments
[]string, io utils.
if err != nil {
return nil, errors.Wrap(err, "Error parsing")
}
- return model.DataItemParse(io, dataType, numberOfValues)
+ return model.DataItemParse(io, dataType, numberOfValues, 0)
Review Comment:
This is a generated file and will be replaced by an updated version,
effectively reverting your changes the next time "mvn install" is executed in
the parent.
##########
plc4go/protocols/modbus/readwrite/XmlParserHelper.go:
##########
@@ -51,7 +51,7 @@ func (m ModbusXmlParserHelper) Parse(typeName string,
xmlString string, parserAr
return nil, err
}
numberOfValues := uint16(parsedUint1)
- return
model.DataItemParse(utils.NewXmlReadBuffer(strings.NewReader(xmlString)),
dataType, numberOfValues)
+ return
model.DataItemParse(utils.NewXmlReadBuffer(strings.NewReader(xmlString)),
dataType, numberOfValues, 0)
Review Comment:
This is a generated file and will be replaced by an updated version,
effectively reverting your changes the next time "mvn install" is executed in
the parent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
