hongjinlin commented on PR #545: URL: https://github.com/apache/plc4x/pull/545#issuecomment-1375071236
> In general, the changes look good, however you manually seem to have edited generated code, so the changes will get lost the next time the maven build is executed. Hi Chris, Thank you very much for reviewing the code. I have a revert commit(https://github.com/apache/plc4x/commit/8a793e26d8b24060ee657d7ca9e6114d89c724a1) of this commit(https://github.com/apache/plc4x/commit/17d7f765c670f86c3fd110f010a3faafe8ee1c5a) after Ben remind me that the Golang build failed after my push, sorry for that. The reason the Golang build failed is just what you said I edited generated file directly. But don’t worry I will be familiar with the code generation and have a PR for that as soon as possible. Jinlin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
