nielsbasjes opened a new pull request, #732:
URL: https://github.com/apache/plc4x/pull/732
This is my proposed set of (what I think are) improvements for the ModbusTag
code.
Summary:
- The equals and hashcode were incorrect because the name of the actual
class also matters.
- My take on reducing the confusion around the -1 offset and the code
complexity around all of this:
- Simplified the code for readability
- There is now a getLogicalAddress which returns the address the user
configured.
- The getAddressString returns a string that parses (which was not the
case) AND yields an identical new tag when parsed (which was not the case: was
shifted by 1 most of the time).
- A more extensive set of tests that verifies all of this and ensures all
supported formats for all tags yield the correct tag that is identical
regardless of the used format.
Looking forward to your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
