chrisdutz commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072120717
##########
plc4j/drivers/ads/src/main/java/org/apache/plc4x/java/ads/protocol/AdsProtocolLogic.java:
##########
@@ -136,11 +136,11 @@ public void onConnect(ConversationContext<AmsTCPPacket>
context) {
// otherwise just mark the connection as completed instantly.
setupAmsRouteFuture.whenComplete((unused, throwable) -> {
if (!configuration.isLoadSymbolAndDataTypeTables()) {
- future.completeExceptionally(new PlcConnectionException(
- "Lazy loading is generally planned, but not implemented
yet. " +
- "If you are in need for this feature, please reach out
to the community."));
- }
- //if (configuration.isLoadSymbolAndDataTypeTables()) {
+ context.fireConnected();
+// future.completeExceptionally(new PlcConnectionException(
Review Comment:
No ... it's a first step to make it possible to still connect to an ADS
without loading the symbol table (if you just use raw addresses) ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
