glcj opened a new pull request, #771:
URL: https://github.com/apache/plc4x/pull/771
Hello,
The original design of the S7 driver delegates the closing of the created
tasks to the GC, which does not guarantee that they are closed
deterministically.
In practice, it is always advisable to call the closure of tasks in a
planned way and not delegate it to the GC.
The "RequestTransactionManager" is modified, to which a public "shutdown"
method is added to end the group of associated tasks in a scheduled manner.
"S7ProtocolLogic" is changed so that during the "onDisconnect" process, all
tasks associated with the driver are called to end.
The task groups are identified in such a way to facilitate their diagnosis
with the profiler.
Added some additional fields that will be required for the high availability
("HA") version of the driver.
Multiple tests are carried out, and it always ends correctly without leaving
ghost tasks.
Best regards,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
