Re: [PR] New various Changes for #1 (plc4x)

[via GitHub]

spnettec commented on code in PR #818:
URL: https://github.com/apache/plc4x/pull/818#discussion_r1115422128


##########
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/messages/DefaultPlcWriteRequest.java:
##########
@@ -194,6 +196,9 @@ public PlcWriteRequest build() {
                 PlcTag tag = tagValues.getLeft().get();
                 Object[] value = tagValues.getRight();
                 PlcValue plcValue = valueHandler.newPlcValue(tag, value);
+                if (tag.getPlcValueType() == PlcValueType.NULL && value!=null) 
{
+                    tag.setPlcValueType(plcValue.getPlcValueType());
+                }

Review Comment:
   
![image](https://user-images.githubusercontent.com/1769060/220867841-3be0d2e4-d740-44cd-aaaf-fc2ae2b58d2a.png)
   
   I want to change plc4x tagAddress can praser other driver. eg:  
%DB2:94:STRING(10), %DB2:78:LREAL[2]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org