sruehl commented on code in PR #962:
URL: https://github.com/apache/plc4x/pull/962#discussion_r1217681247
##########
plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/protocol/OpcuaProtocolLogic.java:
##########
@@ -195,7 +195,7 @@ public CompletableFuture<PlcReadResponse>
read(PlcReadRequest readRequest) {
future.complete(new DefaultPlcReadResponse(request,
status));
return;
}
- } catch (ParseException e) {
+ } catch (Exception e) {
Review Comment:
```suggestion
} catch (ParseException|PlcRuntimeException e) {
```
This would be a better approach then (e.g Exception is also catching
InterruptedException)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
