GitHub user sruehl added a comment to the discussion: Refactor the Subscription API?
Only downside is that it is a bit inconsistent. What about having a UnsubscribeRequest which needs the handle as argument to work? With inconsistent I mean that all those top level Requests are meant to send something to the device, which you would do actually. Calling unsubscribe only on the handle doesn't communicate that clearly. So the handle would be just a token of subscription in my eyes (also it is fine to add callback on it) but communication with the PLCs is always those top level requests. GitHub link: https://github.com/apache/plc4x/discussions/1037#discussioncomment-6563223 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
