sruehl commented on code in PR #1088:
URL: https://github.com/apache/plc4x/pull/1088#discussion_r1311251604
##########
plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcValue.java:
##########
@@ -149,4 +149,10 @@ public interface PlcValue {
Map<String, ? extends PlcValue> getStruct();
+ Map<String, PlcValue> getMetaData();
+
+ boolean hasMetaData(String key);
+
+ PlcValue getMetaData(String key);
Review Comment:
not sure if those are worth it if you expose a map anyway. This just bloats
the API
##########
plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcValue.java:
##########
@@ -149,4 +149,10 @@ public interface PlcValue {
Map<String, ? extends PlcValue> getStruct();
+ Map<String, PlcValue> getMetaData();
+
+ boolean hasMetaData(String key);
Review Comment:
not sure if those are worth it if you expose a map anyway. This just bloats
the API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
