takraj commented on code in PR #1139:
URL: https://github.com/apache/plc4x/pull/1139#discussion_r1357195370


##########
plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/context/SecureChannel.java:
##########
@@ -1071,7 +1070,16 @@ private void keepAlive() {
                             .unwrap(apuMessage -> 
encryptionHandler.decodeMessage(apuMessage))
                             .check(p -> p.getMessage() instanceof 
OpcuaOpenResponse)
                             .unwrap(p -> (OpcuaOpenResponse) p.getMessage())
-                            .check(p -> p.getRequestId() == transactionId)
+                            .check(p -> {

Review Comment:
   Removed in 54c0189



##########
plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/context/SecureChannel.java:
##########
@@ -1096,8 +1104,16 @@ private void keepAlive() {
                     } catch (SerializationException | ParseException e) {
                         LOGGER.error("Unable to to Parse Open Secure Request");
                     }
+
+                    try {
+                        Thread.sleep((long) Math.ceil(this.sessionTimeout * 
0.25f));
+                    } catch (InterruptedException e) {
+                        LOGGER.trace("Interrupted Exception");

Review Comment:
   Added in 54c0189



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to