chrisdutz commented on code in PR #1166:
URL: https://github.com/apache/plc4x/pull/1166#discussion_r1365397240
##########
plc4j/tools/plc4x-server/pom.xml:
##########
@@ -88,15 +88,16 @@
<dependency>
<groupId>org.apache.plc4x</groupId>
- <artifactId>plc4j-driver-simulated</artifactId>
+ <artifactId>plc4j-driver-plc4x</artifactId>
Review Comment:
Woudln't the plc4x driver be part of the all package?
##########
plc4j/examples/plc4j-s7event/pom.xml:
##########
@@ -72,6 +63,13 @@
<version>0.12.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.plc4x</groupId>
+ <artifactId>plc4j-driver-all</artifactId>
Review Comment:
The S7event example is strongly tied to only the S7 driver ... not sure it
makes sense to use the all-drivers module here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
