chrisdutz commented on code in PR #1179:
URL: https://github.com/apache/plc4x/pull/1179#discussion_r1376205060
##########
plc4j/drivers/ads/pom.xml:
##########
@@ -140,11 +140,6 @@
<artifactId>plc4j-transport-tcp</artifactId>
<version>0.12.0-SNAPSHOT</version>
</dependency>
- <dependency>
- <groupId>org.apache.plc4x</groupId>
- <artifactId>plc4j-transport-serial</artifactId>
Review Comment:
Well after the refactoring, everything using the serial no longer explicitly
imported any of the types of the serial module. We're now using the normal
defaults from the serial transport. So if I hadn't removed it, the dependncy
plugin would have failed the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
