splatch commented on PR #1007: URL: https://github.com/apache/plc4x/pull/1007#issuecomment-1907665785
Rebase is not an issue. I think hardest part was getting it after all fixes we had prior 0.11 release. I'd prefer to keep these four commits as they are, simply because first one is made by someone else (maybe we can squash failing unit test). Then there is mspec update which, for ease of porting to other languages, I'd leave alone too. Last commit is update of driver logic and adjustment of encryption logic which is large enough on its own to be left alone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
