chrisdutz commented on PR #1007: URL: https://github.com/apache/plc4x/pull/1007#issuecomment-1907696767
The one thing I'm a bit worried about is that the mspec changes seem to imply a completely different structure ... so I'm a bit worried about which ones are actually the right ones? Were the changes only affecting message types that haven't been used in the past (Possibly still not being used)? If they were not used in the past, I guess updating the mspec doesn't cause any harm. If they have been used, I wonder which is the right format. One option would be to create a new "version" of the mspec (You know that we can provide multiple versions of an mspec and simply reference the version we want in the code-generator. So technically we could reference version 2 in java and version 1 in go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org