hutcheb commented on code in PR #1581:
URL: https://github.com/apache/plc4x/pull/1581#discussion_r1588877124


##########
plc4py/plc4py/drivers/modbus/ModbusConfiguration.py:
##########


Review Comment:
   Wait, we can do that? 



##########
plc4py/plc4py/drivers/modbus/ModbusConnection.py:
##########


Review Comment:
   This removes the timeout. The timeout can be handled better, but I like 
having them in a certain points as a catch all in case it gets into the 
situation where we get stuck in a loop.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to