So, I’ve started reverting the PR and moving the WORD-SWAP code into the Modbus protocol, as this is the only place I have ever seen it be needed. Problem is, that the byte-reordering works with 16, 32, 64 bit, but is a nightmare with any of the partial … especially ADS makes heavy use of uint 32 Little Endian … Simply adding the byte-shift at the end for Little endian did make things work again, but even starting to think about how this would work for Little-Endian-Word-Swap was something I was not willing to investigate ;-)
Chris Von: Christofer Dutz <christofer.d...@c-ware.de> Datum: Freitag, 14. Juni 2024 um 16:41 An: dev@plc4x.apache.org <dev@plc4x.apache.org> Betreff: Issues caused by the Endianness PR Hi all, I thought it would be simpler for me to merge the PR and then add the missing Apache Header … turns out that the PR has serious side-effects on other protocols. Generally when haing 32 unsigned types in mspec, now everything is missed up … I’m working on it. Chris
