chrisdutz commented on code in PR #1786:
URL: https://github.com/apache/plc4x/pull/1786#discussion_r1774600293
##########
plc4j/drivers/ads/src/main/java/org/apache/plc4x/java/ads/tag/SymbolicAdsTag.java:
##########
@@ -37,8 +37,7 @@
*/
public class SymbolicAdsTag implements AdsTag {
- // TODO: Model the end of this address to allow usage of multi-dimensional
arrays.
- private static final Pattern SYMBOLIC_ADDRESS_PATTERN =
Pattern.compile("^(?<symbolicAddress>.+)");
+ private static final Pattern SYMBOLIC_ADDRESS_PATTERN =
Pattern.compile("^([\\w_]+)(\"[\"\\d*]\")*(\\.(\\w+)(\"[\"\\d*]\")*)*");
Review Comment:
I'm still working on this.... It's all still WIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
