chrisdutz commented on code in PR #1850:
URL: https://github.com/apache/plc4x/pull/1850#discussion_r1820325815
##########
protocols/s7/src/main/resources/protocols/s7/s7.mspec:
##########
@@ -897,6 +897,7 @@
['0x0B' UDINT ['0x07' , 'D' , '4' ,
'INT' , 'INTEGER' , 'IEC61131_UDINT'
, 'false' , 'false' , 'true' ,
'true' , 'true' ]]
['0x0C' LINT ['0x00' , 'X' , '8' ,
'INT' , 'BYTE_WORD_DWORD' , 'IEC61131_LINT'
, 'false' , 'false' , 'false' ,
'true' , 'false' ]]
['0x0D' ULINT ['0x00' , 'X' , '8' ,
'INT' , 'BYTE_WORD_DWORD' , 'IEC61131_ULINT'
, 'false' , 'false' , 'false' ,
'true' , 'false' ]]
+ ['0x1C' COUNTER ['0x1C' , 'X' , '2' ,
'null' , 'OCTET_STRING' , 'IEC61131_INT'
, 'true' , 'true' , 'true' , 'true'
, 'false' ]]
Review Comment:
Hmmm it seems COUNTER has the same code as DATE_AND_TIME ... does that mean
that support of COUNTER now breaks the ability to read DATE_AND_TIME?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
