sruehl commented on code in PR #1902:
URL: https://github.com/apache/plc4x/pull/1902#discussion_r1858559585
##########
plc4j/drivers/ads/src/main/java/org/apache/plc4x/java/ads/protocol/AdsProtocolLogic.java:
##########
@@ -1199,10 +1199,6 @@ protected CompletableFuture<PlcWriteResponse>
multiWrite(PlcWriteRequest writeRe
protected byte[] serializePlcValue(PlcValue plcValue, String datatypeName)
throws SerializationException {
// First check, if we have type information available.
Review Comment:
so maybe remove that comment too as it doesn't make sense anymore with the
code below removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
