ottobackwards commented on code in PR #229:
URL: https://github.com/apache/plc4x-extras/pull/229#discussion_r1864435143
##########
plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/BasePlc4xProcessor.java:
##########
@@ -301,17 +300,15 @@ protected void evaluateWriteResponse(final ComponentLog
logger, Map<String, ? ex
if (tagsAtError == null) {
tagsAtError = new ArrayList<>();
}
- logger.error("Not OK code when writing the data
to PLC for tag " + tag
- + " with value " +
values.get(tag).toString()
- + " in addresss " +
plcWriteResponse.getTag(tag).getAddressString());
+ logger.warn("Not OK code when writing the data
to PLC for tag {} with value {}", tag, values.get(tag));
codeErrorPresent = true;
tagsAtError.add(tag);
}
}
if (codeErrorPresent) {
- throw new ProcessException("At least one error was
found when while writting tags: " + tagsAtError.toString());
+ logger.warn("At least one error was found when while writting
tags: {}" + tagsAtError);
Review Comment:
You can do that, but the tests have to match? or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
