glcj commented on PR #1833: URL: https://github.com/apache/plc4x/pull/1833#issuecomment-2510351663
The following changes were included in this modification. 1. Reading of a BOOL type from a HoldingRegister is enabled. In this particular case the HR must have a value of 0/1. 2. In the case of Coils and InputRegisters, they are always treated as BIG_ENDIAN, as specified by the standard. 3. In the case of optimized readings the value of the bit is interpreted directly from the acquired buffer and transferred as a short. 4. In all cases of bit readings in arrays or from an optimized call, the bits are returned in a consistent order. 5. All tests provided for the driver pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org