glcj commented on code in PR #1833:
URL: https://github.com/apache/plc4x/pull/1833#discussion_r1865908103
##########
plc4j/drivers/modbus/src/test/java/org/apache/plc4x/java/modbus/base/optimizer/LittleEndianByteSwapTest.java:
##########
@@ -183,9 +184,9 @@ public void testLittleEndianByteSwap() throws Exception {
input.put("variable129", new String[]{"coil:165:BOOL",
"false"});
input.put("variable130", new String[]{"coil:167:BOOL",
"false"});
input.put("variable131", new String[]{"coil:169:BOOL",
"false"});
- input.put("variable132", new String[]{"coil:171:BOOL",
"false"});
+ input.put("variable132", new String[]{"coil:171:BOOL",
"true"});
Review Comment:
To validate that the bit position calculation within the optimization byte
buffer is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
