ottlukas commented on code in PR #1971:
URL: https://github.com/apache/plc4x/pull/1971#discussion_r1910297330


##########
plc4j/tools/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityInterceptor.java:
##########
@@ -520,6 +520,7 @@ static Object getTyped(Class<?> clazz, PlcReadResponse 
response, String sourceFi
 
         // Fallback
         Object responseObject = response.getObject(sourceFieldName);
+        // Assuming getAll() returns a collection or related structure for 
validation

Review Comment:
   First of all welcome the PLC4X Project :-). The question @sruehl  has is why 
do you call the function "getAll()" is the function not called "getObject()" ? 
So where is the function getAll() come from? Where is it called? Other than 
beeing a little bit more precise and answer the question we follow "community 
over code" so every contribution, comment, question, testing etc. is welcome.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to