Hello All,

I added the the Apache license text to 9 of the files below and deleted the
other 2.  This work was done in svn r745976.

Making sure that all files use a single version of the license header would
be a good idea, but might take some work.

RAT has a way to do it. Take a look at

http://svn.apache.org/repos/asf/incubator/rat/main/trunk/rat/rat-core/src/main/java/org/apache/rat/analysis/license/ApacheSoftwareLicense20.java

It only does a minimal check. A full check could be done.

I did a find/grep search on copyright.

There are a few files that show copyright for The POI Project and not the ASF. These are mostly documentation files. They could be quickly fixed as well.

Should we repackage this release with these license and copyright fixes along with a better NOTICE?

Regards,
Dave




regards,
Josh



On Thu, Feb 19, 2009 at 8:57 AM, David Fisher <[email protected]>wrote:

...
(5) I did find and grep on the source tree.
find . -name .svn -prune -o -exec grep -l LICENSE {} \; > file-list
find . -name .svn -prune -o -print \; > file-list2
diff file-list file-list2

There are a handful of source files that are missing the Apache LICENSE
notice:
./java/org/apache/poi/hssf/record/formula/eval/RefEvalBase.java
./scratchpad/src/org/apache/poi/hwpf/model/EscherRecordHolder.java
./scratchpad/src/org/apache/poi/hslf/model/Comment.java
./scratchpad/src/org/apache/poi/hslf/model/MovieShape.java
./scratchpad/src/org/apache/poi/hslf/model/ActiveXShape.java
./testcases/org/apache/poi/poifs/property/AllPOIFSPropertyTests.java
./testcases/org/apache/poi/hssf/usermodel/TestLinkTable.java
./ooxml/java/org/apache/poi/xssf/usermodel/XSSFActiveXData.java
./ooxml/java/org/apache/poi/xssf/util/Charset.java
./ooxml/java/org/apache/poi/xssf/util/CTFontWrapper.java
./ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFont.java

Some of these are empty files.

The best check would be to look for a proper match of the whole LICENSE header in the source files, and also a look for other licenses in a source
file.
...




---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to