https://issues.apache.org/bugzilla/show_bug.cgi?id=47809
--- Comment #4 from Josh Micich <[email protected]> 2009-09-16 17:46:47 PDT --- Major modifications made in svn r816016 There were a few problems with the code as originally submitted: (1) Naming - The name "ToolPack" is not general enough ("AnalysisToolPak" is just one "Add-in" library). The sub-package has been changed to "udf". The classes have been changed to "*UDFFinder". "UDFFinder" refers to any collection of UDFs: external ("Add-ins" libraries) or internal (VB modules). (2) Mutability - Implementors of UDFFinder should be immutable (there is no need to change UDFs once evaluation has begun). (3) Registration - since we are only dealing with evaluation of UDFs, this a concern of the formula evaluator (not the xSSFWorkbook). The patch code seemed to suggest that it was also maintaining the defined name records within the workbook, but that code looked too simple to be complete. I am pretty sure that additional updates needed elsewhere in the LinkTable, like the SUPBOOK records. We will probably need some method that does this (creating DEFINEDNAME records etc for UDFs used in a workbook) to address the parser error you describe above. In any case, the workbook does not need to know about the the UDF evaluation implementation - e.g. the user may be writing formulas but not evaluating them. Please take a look at the changes and make sure that the functionality you desire is still available. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
