https://issues.apache.org/bugzilla/show_bug.cgi?id=51160
--- Comment #3 from Yegor Kozlov <[email protected]> 2011-05-14 09:49:23 UTC --- Hi Alex, Bugzilla is the right place to discuss patches. This way we have a public record of the discussion and can easily track history. I'm leaning towards copmposition. The advantage is that with this approach we can stay untangled from XSSF and don't need to change signatures of XSSFSheet#getRow and XSSFSheet#createRow. My concern is compatibility with existing client code (including products I wrote for my company). There can be legacy code assuming that XSSFSheet#createRow returns XSSFRow, not Row and your changes would broke it. So, please refactor your patch to use composition instead of subclassing. I would like to check it in and include in the next beta. At first glance, SXSSF handles images correctly. I ran org.apache.poi.xssf.usermodel.examples.WorkingWithPictures from POI examples, only modified it to construct SXSSFWorkbook instead of XSSFWorkbook and the output looks good. Do you call XSSFPicture#resize() after you add it to a drawing? This is the place where the image is resized relative to its top-left corner. Regards, Yegor -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
