https://issues.apache.org/bugzilla/show_bug.cgi?id=51160

--- Comment #11 from Yegor Kozlov <[email protected]> 2011-05-19 12:14:38 UTC ---
I did a deeper review of SXSSSF and made a lot of small fixes, mostly to have
the commented tests pass. I'm happy with the result. There are 9 disabled tests
of 57, but these involve operations not supported in SXSSF:

1. evalution of formulas. 
2. cloning of sheets
3. shifting rows

Other than that the API works fine and fully conforms to the POI spreadsheet
interfaces.

 Below is a summary if my changes:

 SXSSFWorkbook
   - cloneSheet does not make sense in SXSSF throws NotImplemented

 SXSSFSheet
   - added support for blank, boolean, error and formula cells 
   - fixed getFirstRowNum() and getLastRowNum()  to return 0 if there are no
rows. The old code threw NoSuchElement exception.
   - removeRow(Row row) throws exception if the argument row belongs to a
different sheet

 SXSSFRow
   - getCell(int cellnum) validates the input argument and throws
IllegalArgumentException if it is < 0.
   - getCell(int cellnum) respects MissingCellPolicy and returns either null or
blank depending on the workbook settings.
   - getLastCellNum() returns -1 if there are no cells.
   - Constructed FilledCellIterator points to the first cell (was to
cellIndex=0 which isn't always the case)

 SXXSFCell
   - misc fixes related to conversion of cell types. For example, if you create
a string cell and then change its type to boolean then then string value must
be converted and if it was "TRUE" or 1 then the boolean value=true. 
   - getCellStyle() always returns not-null. Default cell style has zero index
and can be obtained as workbook.getCellStyleAt(0)
   - implememented toString()


Committed in r1124698. Shout if I've done something wrong.


Regards,
Yegor

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to