https://issues.apache.org/bugzilla/show_bug.cgi?id=51196

--- Comment #5 from Yegor Kozlov <[email protected]> 2011-05-18 12:01:53 UTC ---
Roman,

Good work! I'm reviewing your patch. All looks good and I'm going to apply it
whithin a day or two.

A couple of comments: 

 (1)  In ChartAxis you are using the Double object instead of the primitive
double.  Do you mind if we switch it to use the primitive type?

 (2) We compile POI with the Java language level 5.0 which means that @Override
in interfaces isn't supported. Please remove.

Other than that, very cool! There is only a few tests for now, but I'm sure
there will be more :)

Regards,
Yegor

(In reply to comment #4)
> I have also added a draft of example
> `src/examples/src/org/apache/poi/xssf/usermodel/examples/ScatterChart.java' to
> demonstrate the api in action (I have not tested it yet, it just compiles, but
> I have very similar code in my application that works fine). Charts generated
> with the api open fine in MS Office 2007 and OpenOffice 3.3 (of course, they
> look much more prettier in ms office).
> 
> Unfortunately, I have a problem with
> `poi-ooxml-schemas-3.8-beta3-TIMESTAMP.jar' file build. When I am trying to 
> run
> my application with it, I got `java.lang.ClassNotFoundException'. So I am
> forced to use `ooxml-schemas-1.1.jar' to run my application.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to