https://issues.apache.org/bugzilla/show_bug.cgi?id=51196
--- Comment #6 from Roman Kashitsyn <[email protected]> 2011-05-18 12:43:30 UTC --- Hi Yegor, (1) I thought about using primitive types, but there is a problem: these parameters are not required and they don't have default values. So we need to inform user if requested parameter has not been set. To return null is the most simple way to do it. Another way is to use primitives and provide additional isSetXXX() methods and return NaN if requested parameter is not set. How do you think, should I introduce the second approach? (2) Ok, no problems. I will try to provide cumulative patch within two days. Best regards, Roman (In reply to comment #5) > Roman, > > Good work! I'm reviewing your patch. All looks good and I'm going to apply it > whithin a day or two. > > A couple of comments: > > (1) In ChartAxis you are using the Double object instead of the primitive > double. Do you mind if we switch it to use the primitive type? > > (2) We compile POI with the Java language level 5.0 which means that > @Override > in interfaces isn't supported. Please remove. > > Other than that, very cool! There is only a few tests for now, but I'm sure > there will be more :) > > Regards, > Yegor -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
