On Thu, 28 May 2015, Allison, Timothy B. wrote:
As ongoing penance for my regrettable past (really it is behind me...I
hope...), I'd like to start cleaning up some of the code whenever I come
across style issues. I'll follow the guidance of fixing whitespace in
separate patches from content patches.
I found this:
https://poi.apache.org/resolutions/res001.html
That's 13 years old now, so much of it has been replaced / overriden. We
probably want to make that clear at the top? Patches / commits for that
welcome!
and this:
https://poi.apache.org/guidelines.html#CodeStyle
That's the one we should be all using now. If there's any gaps in what it
says, we should agree + add them!
Basic questions:
1) spaces are we aiming for four spaces?
2) brace spacing, I'm assuming ) { ..with one space and not put into next line.
3) new lines: lf
4) don't use wildcards on imports
5) Import order:
static
NEWLINE
java
NEWLINE
javax
NEWLINE
Everything else
Probably... Looks roughly right at a first glance... Best check
https://poi.apache.org/guidelines.html#CodeStyle and flag up any not
clear! :)
This about right? Other issues/points?
I believe that the eclipse project settings should be getting most of
these for eclipse users. If we spot anything wrong / agree any changes, we
should update them. If an Idea user wants to contribute some matching
project files for that, they'd be great too, provided they match!
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
