On 5/29/2015 10:31 AM, Allison, Timothy B. wrote:
Thank you, Nick and Andi.

Can we limit this to X classes per package or X static imports?

I have a preference to avoid wildcards altogether.  In the ooxml classes, it 
makes it easier to confirm that I'm triggering the classes that we need 
downstream in ooxml-schemas for Tika.

I defer, though, to you and the other devs on this item.

I'm not a dev for POI, but in the code I maintain, I avoid wildcard imports like the plague, no matter how many it needs! Cold folding in Eclipse takes care of the visual issue.

It's much easier to debug that way, and to ensure that I have the exact ones I want when they are all explicit.




-----Original Message-----
From: Andreas Beeker [mailto:[email protected]]
Sent: Thursday, May 28, 2015 5:11 PM
To: POI Developers List
Subject: Re: style guidelines?

On 28.05.2015 21:36, Allison, Timothy B. wrote:
4) don't use wildcards on imports

This is something I'd like to  change.
Can we limit this to X classes per package or X static imports?

For common_sl, I've used a setting of 3 full imports, and for a higher number 
wildcards will be used.
The only ambiguity which comes up regularly is java.util/awt.List

It's ok if we decide differently, there's a shortcut for it in Eclipse ... 
before I merge the branch.

Andi



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]




---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to