https://bz.apache.org/bugzilla/show_bug.cgi?id=57840
Javen O'Neal <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO --- Comment #7 from Javen O'Neal <[email protected]> --- Thanks for the quick turn around Greg! I'm slowly reviewing what you have. I committed StructuredReferences.xlsx in r1747482. I also added svn:eol-style=native to all the files in your patch so the diffs are shorter when reviewing these changes on a different OS. The import change on Match.java isn't needed. 1. Could you change String Table.isStructuredReference to a compiled Pattern for performance? 2. We're trying to move all junit3 tests to junit4 tests. Could you update TestStructuredReferences.java to use junit4 (org.junit.Test with @Test decorators, see TestXSSFFormulaParser.java for an example) 3. The changes to XSSFRowShifter looks like formulas with structured references cannot be row-shifted. Is that correct? If so, could you either fix that in your patch or open a new bug that depends on bug 57840? 4. Add a javadoc to XSSFWorkbook.getTable. This method rebuilds the table cache and returns a single item. If the cache isn't used elsewhere, then a non-caching linear search would be faster and use less memory. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
