https://bz.apache.org/bugzilla/show_bug.cgi?id=57840
GW <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW --- Comment #9 from GW <[email protected]> --- (In reply to Javen O'Neal from comment #7) > Thanks for the quick turn around Greg! > I'm slowly reviewing what you have. I committed StructuredReferences.xlsx in > r1747482. > I also added svn:eol-style=native to all the files in your patch so the > diffs are shorter when reviewing these changes on a different OS. > The import change on Match.java isn't needed. > > 1. Could you change String Table.isStructuredReference to a compiled Pattern > for performance? > 2. We're trying to move all junit3 tests to junit4 tests. Could you update > TestStructuredReferences.java to use junit4 (org.junit.Test with @Test > decorators, see TestXSSFFormulaParser.java for an example) > 3. The changes to XSSFRowShifter looks like formulas with structured > references cannot be row-shifted. Is that correct? If so, could you either > fix that in your patch or open a new bug that depends on bug 57840? > 4. Add a javadoc to XSSFWorkbook.getTable. This method rebuilds the table > cache and returns a single item. If the cache isn't used elsewhere, then a > non-caching linear search would be faster and use less memory. Updated attachment has the requested changes. Thanks for the feedback, I've been a long time user but this is my first patch. Here are responses to your questions and comments: 1. Yes, changed. I missed this from the original patch I started from, thanks. 2. Done. The example test I picked turned out to be one not yet updated :) 3. Structured Reference syntax doesn't reference individual rows directly, so shifting things doesn't affect these. See the MS documentation link in the initial description. All structured reference syntax is to table columns and parts (#Data, #Headers, etc.) Formula evaluation dynamically constructs a 3DArea for the reference based on the current Table definition (I'm only caching references to the XSSFTable objects, not their start/end cell definitions). Since those objects already existed, my assumption was that inserting/deleting rows above a XSSFTable already updates the table start/end. If that's not the case, that's an existing bug - I haven't tried it. 4. Added JavaDoc -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
