All, On TIKA-2058 [1], Luis Filipe Nassif attached a patch for POI that _may_ solve a memory leak. We haven't had a chance to test that it solves the problem. The patch looks reasonable to me (it is very short), but I don't know enough about FileBackedDataSource to apply it responsibly. If anyone has a chance to look, it would be great to apply this before we respin. Thank you!
Best, Tim [1] https://issues.apache.org/jira/browse/TIKA-2058 -----Original Message----- From: David North [mailto:dtn-...@corefiling.co.uk] Sent: Tuesday, September 13, 2016 12:09 PM To: POI Developers List <dev@poi.apache.org> Subject: Re: [VOTE] Apache POI 3.15 (RC2) Thanks - sounds good. I guess I'd better change my +1 to a -1 and try to build a fresh RC tomorrow night. On 13/09/16 17:06, Javen O'Neal wrote: > I will commit a fix for this today with the goal for backwards > compatibility. > > Here's the plan: > getX() returns int > getXEnum() returns enum > setX(int) > setX(enum) > > I will also take a look at bug 59907 (client anchor enum) > > On Sep 13, 2016 6:58 AM, "David North" <dtn-...@corefiling.co.uk> wrote: > >> Javen, any thoughts on this one? >> >> On 13/09/16 12:14, Dominik Stadler wrote: >>> Hi, >>> >>> I really hate to delay this further, but unfortunately we have a >>> similar problem in class CellValue as we tried to fix in Cell in >>> RC2, the >>> getCellType() is now an enum whereas it was an int before, so >>> something like the following in user-code does break in POI 3.15: >>> >>> CellValue cellValue = checkAndGetCellValue(evaluator, sheet, line); >>> >>> switch (cellValue.getCellType()) { >>> case Cell.CELL_TYPE_STRING: >>> >>> >>> I am sorry that I did not see this earlier but this can lead to the >>> same incompatibility as we had in Cell before. >>> >>> Dominik. >>> >>> On Sun, Sep 11, 2016 at 9:46 PM, David North <dno...@apache.org> wrote: >>> >>>> Hi everyone, >>>> >>>> My apologies for going AWOL in the middle of the last release >>>> attempt. I didn't anticipate that we'd find problems in review >>>> twice in a row, and things have been very busy for me at work >>>> lately. However, I've now rolled a second RC for 3.15. >>>> >>>> https://dist.apache.org/repos/dist/dev/poi/3.15-RC2/ >>>> >>>> Areas to review: >>>> >>>> * Does it work? >>>> * Are the sigs and hashes valid? >>>> * Have the issues with the last RC been fixed? >>>> * Are the release notes now in good shape? >>>> >>>> The vote starts now and ends at 20:55 BST on Tuesday 13 September 2016. >>>> >>>> Here is my +1. >>>> >>>> After this release is done, I'll try and find some time to profile >>>> the build & tests - 15 minutes is quite a wait on an SSD (it's >>>> possible we might want some multi-threaded options on the tests). >>>> >>>> Thanks, >>>> >>>> -- >>>> David North | www.dnorth.net >>>> >>>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional >> commands, e-mail: dev-h...@poi.apache.org >> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org