When I got OOM's with POI because of insufficient heap size, I would
get them when I called wb.write(FileOutputStream).
IIRC I was using POI 3.8 and 3.9 when doing this memory testing.

On Sun, Sep 18, 2016 at 9:54 AM, Dominik Stadler <dominik.stad...@gmx.at> wrote:
> Hi,
>
> As far as I see it only reduces the amount of memory held while the file
> was open, closing correctly already freed up the memory in previous
> versions as well. It also only was visible with read-only access as then we
> do not use memory-mapping. The user seems to have a very large file at some
> point which consumes lots of memory during reading the content and thus the
> memory usage spiked considerably here.
>
> I think we introduced File Backed Data Source in the mainstream via the
> switch to NPOIFS and the actual memory usage later on with a fix for an
> actual memory leak in NIO Java classes where we needed to put in a
> workaround to release memory.
>
> Not sure if it is worthwhile to mention in the release notes as we did not
> do any measurements of actual effect.
>
> Dominik.
>
> On Sat, Sep 17, 2016 at 7:30 PM, Javen O'Neal <javenon...@gmail.com> wrote:
>
>> Is this memory savings seen during regular use of POI, such as the
>> following example, or only when explicitly created with user code calling
>> lower level OPCPackage operations? If so, should release notes mention the
>> lower memory usage for OOXML documents due to File Backed Data Source?
>>
>> Workbook wb = WorkbookFactory.open(file);
>> // Do some things to workbook
>> OutputStrem out = new FileOutputStream(outfile);
>> wb.write(out):
>> wb.close();
>> out.close();
>>
>> On Sep 17, 2016 10:07, "David North" <dno...@apache.org> wrote:
>>
>> > Hi everyone,
>> >
>> > https://dist.apache.org/repos/dist/dev/poi/3.15-RC3/
>> >
>> > Areas to review:
>> >
>> > * Does it work?
>> > * Are the sigs and hashes valid?
>> > * Have the issues with the last RC been fixed?
>> > * Are the release notes (inc requested additions from Javen) OK?
>> >
>> > The vote starts now and ends at 18:15 BST on Monday, 21 September.
>> >
>> > Here is my +1.
>> >
>> > Thanks,
>> >
>> > --
>> > David North | www.dnorth.net
>> >
>> >
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Reply via email to