https://bz.apache.org/bugzilla/show_bug.cgi?id=61474
--- Comment #7 from Javen O'Neal <[email protected]> --- (In reply to Dragan Jovanović from comment #3) > Created attachment 35287 [details] > new class CompleteFormulaShifter, and two minor changes, in patch format CompleteFormulaShifter appears to duplicate what some of the existing code already does. I'd like to see this contribution have a neutral or a net negative SLoC on the codebase. I agree that I'd like to see column shifting (moving, copying, inserting, deleting) implemented eventually. There are still quite a few open issues with row shifting. Besides the open bugs, the API is weak and should be improved (rewritten). I think it'd be wise to resolve the duplicated row-shifting code in HSSF and XSSF and get a solid row-shifting API implemented before moving on to column shifting, unless we can do so without increasing the amount of buggy code with a poor API. Column operations are an order of magnitude more difficult in POI than row operations due to the row-major storage. Open bugs with "shift" in title: bug 46742: Tracker: Remaining functionality for Sheet.shiftRows() bug 56454: XSSFSheet.shiftRows(...) and HSSFSheet.shiftRows(...) incorrectly handle merged regions that do not contain column 0. bug 59733: shiftRows() causes org.apache.xmlbeans.impl.values.XmlValueDisconnectedException bug 57423: shiftRows() produces a corrupted xlsx file bug 60072: Sheet shiftRows doesn't trigger charts position updating bug 59731: Consolidate duplicated code for row shifting bug 53320: FormulaShifter doesn't take care to absolute references bug 58221: Shifting rows while trying to sort causes XmlValueDisconnectedException bug 59306: Shifting rows does not shift chart data series references bug 56123: ShiftRows, Bug in POI 3.10 Beta 2: "Could not find 'internal references' EXTERNALBOOK" bug 54509: Cells in shifting rows are not used in column-referencing formulas. bug 54533: Shifting rows does not shift the Zero Height flag -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
