https://bz.apache.org/bugzilla/show_bug.cgi?id=61474
--- Comment #11 from Dragan Jovanović <[email protected]> --- Started working on this. Moved some logic from CompleteFormulaShifter to FormulaShifter, so now FormulaShifter itsself deals with both rows and columns, and transposing. Removed parsing logic which was in CompleteFormulaShifter, now again HSSF and XSSF pass ptg[] objects to FormulaShifter, so there is no more duplication of code. Introduced class XSSFColumnShifter which should work analog to XSSFRowShifter. Created new class XSSFFormulaShiftingManager. Moved all formula-shifting related methods from XSSFRowShifter to XSSFFormulaShiftingManager. Now both row shifter and column shifter use XSSFFormulaShiftingManager for formula shifting (logic is perfectly same in both cases). Implemented cell-shifting logic in XSSFColumnShifter. Introduced XSSFSheet.shiftColumns() method, similar to XSSFSheet.shiftRow(). At the moment, shiftColumns() can shift cell and formulas. I also have a brief unit test for this. Now I have to deal with all other stuf which exists in shiftRow() method – removing of overwritten items, updateNamedRanges, shiftMergedRegions, updateConditionalFormatting... I see there are no unit tests which cover those subjects in shiftRow(). If you are aware of some other existing tests which can help me test this logic for column shifting, please let me know. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
