https://bz.apache.org/bugzilla/show_bug.cgi?id=63291

--- Comment #7 from Shawn Smith <[email protected]> ---
Thanks!

I haven't actually run your changes locally, but one thing to verify is that
the fix still works if each thread uses a different instance of DataFormatter.

The actual problem call to 'SimpleDateFormat' occurs from this line:

  new CellFormatResultWrapper( cfmt.apply(cellValueO) )

which is wrapped by the 'private synchronized Format getFormat' which
synchronizes on the DataFormatter instance, not globally.  I have a concern
that two different DataFormatter instances could still race on the same
instance of 'SimpleDateFormat'.  The test case doesn't cover this.

It might be better to add the 'synchronize' to the
CellDateFormatter.formatValue() method instead of to the methods in
DataFormatter.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to