https://bz.apache.org/bugzilla/show_bug.cgi?id=63291
Greg Woolsey <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #8 from Greg Woolsey <[email protected]> --- You are right, I can make the updated test fail by using two different concurrent DataFormatter instances. Since all the other format types appear to be thread-safe, I think it is best to make thread safety a documented part of the CellFormatter abstract methods. Then CellDateFormatter can handle its own synchronization on the specific SimpleDateFormat instances, as you suggest. Removing synchronized from DataFormatter.getFormat() and adding it to CellDateFormatter.formatValue() passes the updated test that fails for multiple concurrent DataFormatter instances, which I believe is a superset of the testing for a single DataFormatter instance, so this change fixes all the cases. committed in revision 1856647. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
