https://bz.apache.org/bugzilla/show_bug.cgi?id=64045

--- Comment #6 from radistao <[email protected]> ---
@dominik.stadler and @fanningpj

I tested current sources
(https://github.com/apache/poi/commit/4aa8334e3b695cc34a2bfb035b9cc35dc9271e73)
on my project - can't reproduce "Cleaning up unclosed ZipFile for archive" any
more! Thank you.

> So a good way to help poi-devs would be to provide patches for unit-tests 
> which actually trigger the remaining cases.
I'd like to do this, but the solution and the test cases are quite huge, so
hard to do this without a good introduction to the sources from actual
developers.

> can you point out in more detail how you think those can leak file-handles?
That weren't real cases, just my assumption based on the sources, but as i
mentioned above - i don't see the entire picture.

BUT! When i run the gradle tests locally for ooxml subroject (`gradle --info
--console=verbose :ooxml:clean :ooxml:test`) I see 2 another stderr traces
about unclosed ZipFile:

1) 
>org.apache.poi.xddf.usermodel.chart.TestXDDFChartRemoveSeries > 
>testRemoveSeries0 STANDARD_OUT
>    testRemoveSeries0: test file written to 
> /home/andrii/workspace/poi-report/poi/build/ooxml/build/custom-reports-test/testRemoveSeries0.xlsx
>org.apache.poi.openxml4j.opc.internal.TestContentTypeManager > 
>testContentTypeRemovalPackage SKIPPED
>org.apache.poi.openxml4j.opc.TestPackage > removePartRecursive SKIPPED
>org.apache.poi.util.TestTempFileThreaded > runTest STANDARD_ERROR
>    Cleaning up unclosed ZipFile for archive 
> /home/andrii/workspace/poi-report/poi/test-data/openxml4j/TestPackageCommon.docx
>org.apache.poi.util.TestTempFileThreaded > runTest STANDARD_OUT
>    thread: 7, iter: 0: 
> /tmp/poifiles/TestTempFileThreaded/26/TestTempFile-7-0-5000898654042792707.xlsx
>    thread: 0, iter: 0: 
> /tmp/poifiles/TestTempFileThreaded/19/TestTempFile-0-0-9041124478588812993.xlsx
>    thread: 5, iter: 0: 
> /tmp/poifiles/TestTempFileThreaded/24/TestTempFile-5-0-4091795158149176089.xlsx

2) 
>org.apache.poi.xssf.streaming.TestSXSSFCell > 
>setCellFormula_isExceptionSafe_onBlankCell SKIPPED
>org.apache.poi.xssf.streaming.TestSXSSFCell > 
>setBlank_throwsISE_ifCellIsPartOfAnArrayFormulaGroupContainingOtherCells 
>SKIPPED
>org.apache.poi.xssf.usermodel.TestXSSFBugs > test54764WithSAXHelper 
>STANDARD_ERROR
>    [Fatal Error] :1:1: JAXP00010001: The parser has encountered more than "1" 
> entity expansions in this document; this is the limit imposed by the JDK.
>org.apache.poi.xssf.usermodel.TestXSSFBugs > bug48877 STANDARD_ERROR
>    Cleaning up unclosed ZipFile for archive 
> /home/andrii/workspace/poi-report/poi/test-data/spreadsheet/54764.xlsx
>org.apache.poi.xssf.usermodel.TestXSSFBugs > test55273 SKIPPED
>org.apache.poi.xssf.usermodel.TestXSSFBugs > test57699 SKIPPED
>org.apache.poi.xssf.usermodel.TestXSSFBugs > test58043 SKIPPED
>org.apache.poi.xssf.usermodel.TestXSSFBugs > testSetRGBBackgroundColor SKIPPED
>org.apache.poi.xssf.usermodel.TestXSSFBugs > testBug53798XLSXStream SKIPPED
>org.apache.poi.xssf.usermodel.TestXSSFBugs > testBug56688_3 STANDARD_ERROR
>    Cleaning up unclosed ZipFile for archive 
> /home/andrii/workspace/poi-report/poi/test-data/spreadsheet/54764.xlsx
>org.apache.poi.xssf.usermodel.TestXSSFBugs > bug46670 SKIPPED
>org.apache.poi.xssf.usermodel.TestXSSFBugs > 
>bug59393_commentsCanHaveSameAnchor SKIPPED
>org.apache.poi.xssf.usermodel.TestXSSFBugs > test57929 SKIPPED

**Do you think these could be some undiscovered cases?**

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to