https://bz.apache.org/bugzilla/show_bug.cgi?id=64045

--- Comment #7 from radistao <[email protected]> ---
Another thing which confuses me a bit:
Considering these changes in `XSSWorkbook#newPackage(XSSFWorkbookType)`:
 -
https://github.com/apache/poi/compare/adb8424bc1a1c9a502d2cd07757615b711d32c50..4aa8334e3b695cc34a2bfb035b9cc35dc9271e73#diff-512a44831b35fadfdff4e2cd0bb33374
 -
https://github.com/apache/poi/blob/fb8f17190064f39f8f35700aa6ba1fbc2cfd88e1/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java#L495-L495

now the implementation looks diverse from similar one in
`XWPFDocument#newPackage()`:
https://github.com/apache/poi/blob/fb8f17190064f39f8f35700aa6ba1fbc2cfd88e1/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFDocument.java#L156-L156

I mean the `try-catch` block with following `IOUtils.closeQuietly(pkg);`.
>From the first view:
  - either it doesn't have sense in `XSSWorkbook`
  - or it also shall be used in `XWPFDocument`

Do you understand what i mean?

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to