focJSi commented on code in PR #954:
URL: https://github.com/apache/poi/pull/954#discussion_r2565572374
##########
poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java:
##########
@@ -122,6 +122,7 @@ public class XSSFWorkbook extends POIXMLDocument implements
Workbook, Date1904Su
public static final int PICTURE_TYPE_EPS = 10;
public static final int PICTURE_TYPE_BMP = 11;
public static final int PICTURE_TYPE_WPG = 12;
+ public static final int PICTURE_TYPE_SVG = 14;
Review Comment:
`org.apache.poi.common.usermodel.PictureType.WDP` has `ooxmlId` 13, which is
missing here.
##########
poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java:
##########
@@ -122,6 +122,7 @@ public class XSSFWorkbook extends POIXMLDocument implements
Workbook, Date1904Su
public static final int PICTURE_TYPE_EPS = 10;
public static final int PICTURE_TYPE_BMP = 11;
public static final int PICTURE_TYPE_WPG = 12;
+ public static final int PICTURE_TYPE_SVG = 14;
Review Comment:
`org.apache.poi.common.usermodel.PictureType.WDP` has `ooxmlId` 13, which is
missing here.
Should these constants be refactored to use
`org.apache.poi.common.usermodel.PictureType#ooxmlId` in a seperate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
