rPraml commented on code in PR #954:
URL: https://github.com/apache/poi/pull/954#discussion_r2567624506
##########
poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFPictureData.java:
##########
@@ -143,6 +143,37 @@ void testNewPictFormat() throws IOException {
}
}
+ @Test
+ void testNewSvgFormat() throws IOException {
+ try (XSSFWorkbook wb = new XSSFWorkbook()) {
+ XSSFSheet sheet = wb.createSheet();
+ XSSFDrawing drawing = sheet.createDrawingPatriarch();
+
+ byte[] data = "test svg
data".getBytes(LocaleUtil.CHARSET_1252);
Review Comment:
This is not a valid svg image data (which should not be relevant for this
test).
But maybe you can use a valid svg string, so it will not break if someone
adds a SVG->PNG converter for backward compatibility
https://dev.w3.org/SVG/tools/svgweb/samples/svg-files/decimal.svg, for
example:
```xml
<svg viewBox='0 0 125 80' xmlns='http://www.w3.org/2000/svg'>
<text y="75" font-size="100" font-family="serif"><![CDATA[10]]></text>
</svg>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
