tballison opened a new pull request, #1043:
URL: https://github.com/apache/poi/pull/1043
This attempts to decouple xmlbeans from xlsb.
The one area of concern I have is the public api change:
XSSFSheetXMLHandler.SheetContentsHandler.cell(String, String, XSSFComment) →
cell(String, String, Comment)
This is:
* Source-compatible: Comment is a supertype of XSSFComment, so existing
implementations that reference XSSFComment just need to change their parameter
type and recompile
* Binary-incompatible: Any compiled code implementing SheetContentsHandler
will need recompilation against the new version
If this is a bridge too far, we can try to refactor in another way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
