pjfanning commented on code in PR #1043:
URL: https://github.com/apache/poi/pull/1043#discussion_r3047267859
##########
poi-ooxml/src/main/java/org/apache/poi/xssf/binary/XSSFBSheetHandler.java:
##########
@@ -447,9 +447,9 @@ public interface XSSFBSheetContentsHandler {
* </code>. See the code in <code>
*
poi-examples/src/main/java/org/apache/poi/xssf/eventusermodel/XLSX2CSV.java</code>
for an
* example of how to handle this scenario.
- * @see #doubleCell(String, double, XSSFComment, ExcelNumberFormat)
+ * @see #doubleCell(String, double, Comment, ExcelNumberFormat)
*/
- void stringCell(String cellReference, String value, XSSFComment
comment);
+ void stringCell(String cellReference, String value, Comment comment);
Review Comment:
these are breaking changes - we have a policy of deprecating APIs and later
removing them
Can we keep the XSSFComment methods and deprecate them adding the Comment
overloads?
Add `@Removal` annotation to the deprecated methods (v7.0.0 removal).
`@since 6.0.0` to the new methods.
If methods are not public then it is ok to change them without this
deprecate and overload approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
